fix(modal): remove non existant cls-panel option #1014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'clsPanel' option got renamed to 'selPanel' which indicates the real usage of it. It's not a css class which will be added for user specifics, but it is a selector for the modal internally. It won't set any classes on the modal element and should be removed from the ember component arguments as well.
derrabauke
force-pushed
the
fix-tidy-up-modal-options
branch
from
02ed940
to
82881d8
Compare
|
|
Since it could not work since ~2019 I guess it's not. 🤷 |
anehx
pushed a commit
that referenced
this pull request
Mar 28, 2023
# [7.0.0](v6.1.1...v7.0.0) (2023-03-28) ### Bug Fixes * **modal:** remove non existant cls-panel option ([#1014](#1014)) ([d3252e5](d3252e5)) ### chore * **deps:** update dependencies ([8df899f](8df899f)) ### Features * added danger color to uk-button ([00159e9](00159e9)) ### BREAKING CHANGES * **deps:** Remove support for deprecated Ember LTS 3.24.
|
🎉 This PR is included in version 7.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
clsPaneloption got renamed toselPanelwhich indicates the real usage of it. It's not a css class which will be added for user specifics, but it is a selector for the modal internally. It won't set any classes on the modal element and should be removed from the ember component arguments as well.Further information:
clsPanel-> selPanel